Repository navigation
Conversation
tapple
force-pushed
the
lute-build-fixes
branch
from
November 10, 2026 09:52
146b0b2 to
606864e
Compare
tapple
force-pushed
the
lute-build-fixes
branch
from
November 10, 2026 09:53
606864e to
dd2f2ff
Compare
HaroldCindy
requested changes
Nov 10, 2026
HaroldCindy
left a comment
HaroldCindy
left a comment
Contributor
There was a problem hiding this comment.
Seems broadly reasonable to me, thanks! Just a couple fixups needed, the web failure is unrelated and probably due to an SDK upgrade.
For future ref, you needn't (and shouldn't) include LLM-generated prose in issues or PRs. I trust your judgment and I'd much prefer a terse human-written issue description than read LLM output.
| configure_file( | ||
| "${CMAKE_SOURCE_DIR}/LSLBuiltins/src/builtins_embedded.h.in" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/LSLBuiltins/src/builtins_embedded.h.in" | ||
| "${CMAKE_BINARY_DIR}/builtins_embedded.h" |
Contributor
There was a problem hiding this comment.
This (and the other CMAKE_BINARY_DIR instance should also be CMAKE_CURRENT_BINARY_DIR so we don't pollute the root project's build dir
|
|
||
| target_compile_features(Luau.LSLBuiltins PUBLIC cxx_std_17) | ||
| target_include_directories(Luau.LSLBuiltins PUBLIC LSLBuiltins/include) | ||
| target_include_directories(Luau.LSLBuiltins PRIVATE ${CMAKE_BINARY_DIR}) # For builtins_embedded.h |
Contributor
There was a problem hiding this comment.
CMAKE_CURRENT_BINARY_DIR here also, or we would be pulling in headers from the project root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small edit to cmake build system that allows slua to be built into lute
SLua still builds properly, but now it also builds as a subdirectory in lute
This change is AI-generated using pi and qwen. it's suggested PR text is below:
When extern/luau is added as a subdirectory (e.g., when lute builds against slua), CMAKE_SOURCE_DIR points to the parent project root, not the luau directory. This causes the builtins embedding to fail because it can't find builtins.txt and
builtins_embedded.h.in in the wrong location.
Using CMAKE_CURRENT_SOURCE_DIR ensures the paths are correct regardless of whether luau is built as a standalone project or as a subdirectory.
Changes:
This fix allows lute to build against slua when using the subdirectory approach.