Repository navigation
Conversation
Builds on the video-first Stage redesign (#71) and takes it across the whole site: a collapsible sidebar, an episode explorer on the home page, a player that stays with you between pages, and an episode page with a resizable stage. Shell - Collapsible sidebar that folds to an icon rail, with the hosts and the follow links in it. The fold is one PropFLIP flight over anchored auto layout, staggered with sibling-index(). - Search stays on Cmd/Ctrl+K and opens over anything, the player card included. Home - An episode explorer in place of the plain list: grid and list views, sort and filters, and a close-up with a filmstrip. Cards fly between views instead of cutting. Player - One media engine behind an island that is a dock, a pill, a corner picture or a full card with an Up next queue, and that survives client-side navigation. - The progress ship and its particles from the original player are on the island's scrubber. Episode page - A stage with Watch / Balanced / Read presets and a draggable divider, a sticky section bar, a live transcript, people cards and sponsors. Motion and state - motion/propflip.ts: FLIP flights with settle and viewport options. - prop-for-that publishes media state and pointer position as custom properties; pointer tracking is bound only while its element is hovered. - Scroll-state and anchor queries where supported, with plain fallbacks. Tests - Unit tests for the engine, queue, scrubber, flights and explorer query. - Playwright specs for the shell, explorer, player and episode page. Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 156 files, which is 56 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the video-first Stage redesign from #71 across the whole site, so the media stays at the centre wherever you are: a collapsible sidebar, an episode explorer on the home page, a player that follows you between pages, and an episode page with a resizable stage.
This branch was built on top of #71 and includes its three commits, squashed in here with @RobbieTheWagner credited as co-author. Merging this makes #71 redundant.
What changes
Shell
sibling-index().Home
Player
Episode page
Motion and state
src/motion/propflip.ts: FLIP flights, withsettleandviewportoptions. A flight no longer cancels the transitions an element lists in--also.Testing
pnpm lint: clean.pnpm test:unit: 229 passed.pnpm build(includesastro check): passes.Known gaps
episode.spec.ts"clicking a timestamp on episode 6 loads it into the player" fails on a cold dev server in Chromium and passes on retry.