Skip to content

refactor(methods): move admin.apps.mcp.servers.permissions examples into a permissions folder - #396

Merged
mwbrooks merged 1 commit into
mainfrom
zimeg-refactor-mcp-servers-permissions-folder
Nov 16, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
zimeg-refactor-mcp-servers-permissions-folder

Conversation

@zimeg

@zimeg zimeg commented Nov 16, 2026

Copy link
Copy Markdown
Member

Summary

This pull request moves the admin.apps.mcp.servers.permissions.list and admin.apps.mcp.servers.permissions.set method examples into methods/src/admin/apps/mcp/servers/permissions/, so the folder mirrors the method name like the other examples.

Testing

  1. cd methods/src/admin/apps/mcp/servers/permissions && slack install --environment local, then export SLACK_TOKEN=... with the app's user token.
  2. slack run admin_apps_mcp_servers_permissions_list.py and confirm the response.
  3. cd .. and repeat with admin_apps_mcp_servers_list.py to confirm admin.apps:read is enough there.

🤖 Generated with Claude Code

…nto a permissions folder

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 16, 2026 23:33
@zimeg zimeg added update PR only - an update or maintenance is being made to an existing app python Pull requests that update python code labels Nov 16, 2026
@zimeg zimeg self-assigned this Nov 16, 2026

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Appreciate this one @zimeg! Giving the permissions examples their own folder and manifest means the servers.list app only asks for admin.apps:read.

@mwbrooks
mwbrooks merged commit ef1d40a into main Nov 16, 2026
16 checks passed
@mwbrooks
mwbrooks deleted the zimeg-refactor-mcp-servers-permissions-folder branch November 16, 2026 23:43
@zimeg

zimeg commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

🌲 Thanks for the kind review and merge @mwbrooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update python code update PR only - an update or maintenance is being made to an existing app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants