Repository navigation
fix(domain): read a release's contact the same way in the Studio - #832
Merged
Merged
Conversation
The Studio's Contact field showed the web page of the first contact point of a release that names one, blank nodes included, while the learner app's "Report a mistake" followed the first contact point that is named. A release that names more than one contact point could so show its creator one contact in the Studio and send learners to another once published. Both now read a release's contact the same way: the one contact point, named or blank, with one web page. A release that names more than one contact point, or a point with more than one web page, names no contact, so "Report a mistake" has no page to lead to, and the Contact field is empty. The release check warns of such a release in a pod and for the library (contactAmbiguous), in every language the Studio speaks. Setting the contact again still writes exactly one point, and a release made a draft keeps its points as they are, for the check to show. The Studio and library docs say so. Refs: GHSA-g8xv-c484-62vx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Studio's Contact field showed the web page of the first contact point of a release, blank nodes included, while the learner app's "Report a mistake" followed the first contact point that is named. A release that names more than one contact point could so show its creator one contact in the Studio and send learners to another once published.
Both now read a release's contact the same way: the one contact point, named or blank, with one web page. A release that names more than one contact point, or a point with more than one web page, names no contact, so "Report a mistake" has no page to lead to and the Contact field is empty. The release check warns of such a release in a pod and for the library (
contactAmbiguous), in every language the Studio speaks. Setting the contact again still writes exactly one point, and a release made a draft keeps its points as they are, for the check to show. The Studio and library docs say so.Refs: GHSA-g8xv-c484-62vx