Repository navigation
Allow diff-lcs 2 - #317
Merged
Merged
Allow diff-lcs 2#317
Conversation
SuperDiff uses only Diff::LCS.traverse_balanced and traverse_sequences and the ContextChange readers (old/new element and position), which diff-lcs 2 keeps. The unit suite gives the same result on 2.0.0 as on 1.6.2.
jas14
reviewed
Nov 6, 2026
jas14
approved these changes
Nov 6, 2026
jas14
left a comment
jas14
left a comment
Collaborator
There was a problem hiding this comment.
Great, thanks @andrewfader !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff-lcs 2.0.0 is out, and
~> 1.5keeps SuperDiff users on 1.x.SuperDiff uses only
Diff::LCS.traverse_balanced,traverse_sequencesand theContextChangereaders (old/new element and position), which diff-lcs 2 keeps. The unit suite gives the same result on 2.0.0 as on 1.6.2.This widens the requirement to
>= 1.5, < 3, keeping a major-version ceiling as #296 does.