Skip to content

feat: python sdk files - #1

Merged
Scarjit merged 2 commits into
mainfrom
feat/init
Oct 27, 2026
Merged

Scarjit merged 2 commits into
mainfrom
feat/init

Conversation

@Scarjit

@Scarjit Scarjit commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@doernemt

doernemt commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Hi team,
while trying out the SDK (smooth experience in general, nice!) I found 1-2 issues in the auth area.

: it assumes a token lifetime of 3600 seconds. The default is 900 already. I'd recommend sth along the lines of

claims = jwt.decode(token, options={"verify_signature": False})
return token, claims["exp"] - time.time()` to make it adjust to reality.

(see core sdk with the open renewal bug: stackitcloud/stackit-sdk-python#3535)

I think that KeyAuth leaks threads by the way you're using it. The constructor starts a ThreadPoolExecutor with 1 background thread. In your auth.py, _get_token_from_stackit(self) creates a new KeyAuth on EVERY token creation or refresh. This means a lot of KeyAuth threads that are never stopped. You should move that code to the provider level.

Thanks, Tim

@PaulicStudios
PaulicStudios added this pull request to stack #3 October 13, 2026 07:59
@Scarjit
Scarjit merged commit 05f59fe into main Oct 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants