Skip to content

feat(git): Add update command for ACLs - #1727

Merged
GokceGK merged 1 commit into
mainfrom
git-acl-adjustements
Nov 10, 2026
Merged

GokceGK merged 1 commit into
mainfrom
git-acl-adjustements

Conversation

@Fyusel

@Fyusel Fyusel commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Extend describe command to show ACLs.

STACKITCLI-555

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel
Fyusel requested a review from a team as a code owner November 4, 2026 11:44
@Fyusel
Fyusel force-pushed the git-acl-adjustements branch 2 times, most recently from 04e6973 to d98e51a Compare November 4, 2026 11:48
@GokceGK

GokceGK commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Not part of this PR, but just recognized while testing. The prompt messages that are used to inform/ confirm, contain text 'stackit git'. I think we should change these to the correct spelling "STACKIT Git."

e.g

prompt := fmt.Sprintf("Are you sure you want to delete the stackit git instance %q for %q?", instanceName, projectName)

@Fyusel
Fyusel force-pushed the git-acl-adjustements branch from 56f01dd to 0cb9522 Compare November 5, 2026 07:01
GokceGK
GokceGK previously approved these changes Nov 9, 2026
Extend describe command to show ACLs.

STACKITCLI-555

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/create 51.02% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/delete 17.78% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe 68.09% (+3.80%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/update 46.15% (+46.15%) 🌟
Coverage details

Compared to commit ac1dddb (run #42647195412)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/create/create.go 51.02% (ø) 49 25 24
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/delete/delete.go 17.78% (ø) 45 8 37
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe/describe.go 68.09% (+3.80%) 47 (+5) 32 (+5) 15 👍
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/instance.go 0.00% (ø) 4 0 4
github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/update/update.go 46.15% (+46.15%) 52 (+52) 24 (+24) 28 (+28) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/git/instance/update/update_test.go

@GokceGK
GokceGK merged commit 1b2c401 into main Nov 10, 2026
5 checks passed
@GokceGK
GokceGK deleted the git-acl-adjustements branch November 10, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants