Skip to content

feat(dns): Onboard lookup command - #1732

Merged
GokceGK merged 1 commit into
mainfrom
dns-onboard-lookup-command
Nov 11, 2026
Merged

GokceGK merged 1 commit into
mainfrom
dns-onboard-lookup-command

Conversation

@Fyusel

@Fyusel Fyusel commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel
Fyusel requested a review from a team as a code owner November 5, 2026 12:29
Comment thread internal/cmd/dns/lookup/lookup.go Resolved
STACKITCLI-454

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel
Fyusel force-pushed the dns-onboard-lookup-command branch from b2c5893 to baddd15 Compare November 11, 2026 10:03
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/dns 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/dns/lookup 77.19% (+77.19%) 🌟
Coverage details

Compared to commit 5a3644a (run #42995088578)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/dns/dns.go 0.00% (ø) 6 (+1) 0 6 (+1)
github.com/stackitcloud/stackit-cli/internal/cmd/dns/lookup/lookup.go 77.19% (+77.19%) 57 (+57) 44 (+44) 13 (+13) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/lookup/lookup_test.go

@GokceGK
GokceGK enabled auto-merge (squash) November 11, 2026 12:21
@GokceGK
GokceGK merged commit 52994ec into main Nov 11, 2026
5 checks passed
@GokceGK
GokceGK deleted the dns-onboard-lookup-command branch November 11, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants