Skip to content

feat(observability): Onboard ACL commands - #1735

Merged
Fyusel merged 2 commits into
mainfrom
onboard-obserablility-acls
Nov 11, 2026
Merged

Fyusel merged 2 commits into
mainfrom
onboard-obserablility-acls

Conversation

@Fyusel

@Fyusel Fyusel commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

STACKITCLI-552

Description

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel
Fyusel requested a review from a team as a code owner November 6, 2026 09:40
@Fyusel
Fyusel force-pushed the onboard-obserablility-acls branch from 0cb21d8 to 11ac586 Compare November 6, 2026 10:04
GokceGK
GokceGK previously approved these changes Nov 10, 2026
@GokceGK GokceGK changed the title feat(observabiltiy): Onboard ACL commands feat(observability): Onboard ACL commands Nov 10, 2026
STACKITCLI-552

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel
Fyusel force-pushed the onboard-obserablility-acls branch from 62ad341 to d4347d5 Compare November 11, 2026 08:39
Co-authored-by: Gökce Gök Klingel <161626272+GokceGK@users.noreply.github.com>
@Fyusel
Fyusel force-pushed the onboard-obserablility-acls branch from d4347d5 to 8ca3f21 Compare November 11, 2026 08:55
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/observability 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/list 59.18% (+59.18%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/update 45.00% (+45.00%) 🌟
Coverage details

Compared to commit 1b2c401 (run #42769240888)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/acl.go 0.00% (ø) 5 (+5) 0 5 (+5)
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/list/list.go 59.18% (+59.18%) 49 (+49) 29 (+29) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/update/update.go 45.00% (+45.00%) 40 (+40) 18 (+18) 22 (+22) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/observability/observability.go 0.00% (ø) 9 (+1) 0 9 (+1)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/observability/acl/update/update_test.go

@Fyusel
Fyusel merged commit 5a3644a into main Nov 11, 2026
5 checks passed
@Fyusel
Fyusel deleted the onboard-obserablility-acls branch November 11, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants