Repository navigation
Add classes to all loo warnings - #417
Open
florence-bockting wants to merge 5 commits into
Open
florence-bockting wants to merge 5 commits into
florence-bockting wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 92.65% 92.92% +0.26%
==========================================
Files 31 31
Lines 3242 3251 +9
==========================================
+ Hits 3004 3021 +17
+ Misses 238 230 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if c74db6b is merged into master:
Further explanation regarding interpretation and methodology can be found in the documentation. |
florence-bockting
marked this pull request as ready for review
November 3, 2026 06:15
jgabry
reviewed
Nov 3, 2026
jgabry
left a comment
jgabry
left a comment
Member
There was a problem hiding this comment.
Looks good. I made a few suggestions, but pretty small.
jgabry
requested changes
Nov 10, 2026
jgabry
left a comment
jgabry
left a comment
Member
There was a problem hiding this comment.
Looks good, this is basically ready. I made a few code formatting (indentation) comments and suggested an edit to the NEWS entry.
| if (ref_loo[[1]]$loo_subsampling$estimator == "hh_pps" | compare_loo[[1]]$loo_subsampling$estimator == "hh_pps"){ | ||
| warning("Hansen-Hurwitz estimator used. Naive diff SE is used.", call. = FALSE) | ||
| .warn_diagnostic("Hansen-Hurwitz estimator used. Naive diff SE is used.", | ||
| class = "loo_warning_subsample_naive_se") |
| } else { | ||
| warning("Negative estimate of SE, more subsampling obs. needed.", call. = FALSE) | ||
| .warn_diagnostic("Negative estimate of SE, more subsampling obs. needed.", | ||
| class = "loo_warning_subsample_negative_se") |
| warning("Negative estimate of SE, more subsampling obs. needed.", call. = FALSE) | ||
| x$estimates["elpd_loo", "SE"] <- NaN | ||
| .warn_diagnostic("Negative estimate of SE, more subsampling obs. needed.", | ||
| class = "loo_warning_subsample_negative_se") |
| ...) { | ||
| .Deprecated("psis") | ||
| .warn("'psislw' is deprecated.\nUse 'psis' instead.\nSee help(\"Deprecated\")", | ||
| class = c("loo_warning_deprecated", "deprecatedWarning")) |
| if (!is.null(log_q)) { | ||
| .Deprecated(msg = "psis_approximate_posterior() argument log_q has been changed to log_g") | ||
| .warn("psis_approximate_posterior() argument log_q has been changed to log_g", | ||
| class = c("loo_warning_deprecated", "deprecatedWarning")) |
Comment on lines
+14
to
+16
| * All warnings now have the class `loo_warning` and a class for each cause; | ||
| diagnostics warnings have the class `loo_warning_diagnostic`. The base warning | ||
| class is now `rlang_warning` by @florence-bockting in #417 |
Member
There was a problem hiding this comment.
Suggested change
| * All warnings now have the class `loo_warning` and a class for each cause; | |
| diagnostics warnings have the class `loo_warning_diagnostic`. The base warning | |
| class is now `rlang_warning` by @florence-bockting in #417 | |
| * All warnings now have the class `loo_warning` and a class for each cause, | |
| and diagnostic warnings also have the class `loo_warning_diagnostic`. The base | |
| warning class is now `rlang_warning` instead of `simpleWarning`. By | |
| @florence-bockting in #417 | |
| * Fix `loo_subsample()` with the Hansen-Hurwitz estimator setting the | |
| `elpd_loo` SE to `NaN` instead of the `p_loo` SE when the `p_loo` variance | |
| estimate is negative by @florence-bockting in #417 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a class to each loo warning, following up on our corresponding work in the
posteriorpackage: stan-dev/posterior#470.loo_warningand a class for its cause.loo_warning_diagnostic.R/loo-package.RrlangtoImports.throw_psis_r_eff_warning()andthrow_loo_r_eff_warning()(this was dead code)This PR is related to Issue #353 (but does not fully solve it).
The PR was assisted by an LLM.