Repository navigation
Conversation
The old step uninstalled Pydantic 2 from the shared virtualenv and had to stay last; uv can layer Pydantic 1 over the project environment for that one test instead. The gevent step was gated on Python 3.12, which is not in the matrix, so it never ran.
DABH
enabled auto-merge (squash)
November 13, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two things in the root
build-lint-testjob.The step named "Uninstall pydantic" is really the Pydantic v1 sample's test. It downgraded the shared virtualenv in place and had to stay last. It now runs that one test with
uv run --with "pydantic>=1.10,<2", which layers Pydantic 1 over the project environment, and disables the langsmith pytest plugin, which needs Pydantic 2.The "Gevent test" step was gated on Python 3.12, which is not in the matrix, so it never ran. It now runs on 3.14.