Repository navigation
Conversation
Add pytest-timeout with a 300 second limit to the root project and the standalone samples, so a stuck test fails with a stack dump and the job finishes instead of sitting at the 30 minute limit with no trace.
Both tests shared one workflow ID and one task queue, and the Sentry client and scopes carried over between them, so a worker or breadcrumb from the first test could show up in the second. Each test now gets its own IDs and a fresh client with cleared scopes.
With fail-fast on, one flaky job cancels the rest and hides whether they would have passed, which has made this week's stalls harder to read.
Diagnostic only, so the Windows failure shows what the third event is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment only, not for merge: #413 (pytest-timeout, fail-fast off) with #415 (Sentry test isolation) on top. The question is whether the Sentry test still captures a stray third event on Windows 3.10 when pytest-timeout is installed, once each test has its own IDs and a fresh Sentry client. If this run's Windows 3.10 job is green, #415 removes the one failure #413 has left, and the two can land in that order.