Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha256sum --checkportability issue in tarball_multi_releases.bash's checksum verification (some coreutils implementations reject our tab-separated checksum file format); verify each entry directly instead.--compare-signing-keys PREV_DIR CURR_DIRto diff signing-key identity between two version directories. Wired into a new tests/key_continuity.bats that dynamically discovers every consecutive point-release pair, and a dedicated.github/workflows/key-continuity.yml.Test plan
bats tests/*.bats— all 21 tests pass, including the newsigning key continuitytests--compare-signing-keyscorrectly flags a known historical key rotation (legacy jsl v1.9 -> v1.9.2) and exits 1--compare-signing-keys v2.15 v2.15.1passes with mtl-s/arl-s reported as new-in-release (informational), exit 0compare_signed_unsigned.pyreports arl-s as matching mtl-s at the module levelshellcheck -e SC3043clean on the new bats file and the existing glob🤖 Generated with Claude Code