Repository navigation
Conversation
ursus161
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
November 17, 2026 09:30
Collaborator
|
Can one of the admins verify this patch?
|
dbaluta
reviewed
Nov 17, 2026
| @@ -195,8 +195,8 @@ __cold static int probe_dma_init(struct probe_dma_ext *dma, uint32_t direction) | |||
| { | |||
| uint32_t addr_align; | |||
Collaborator
There was a problem hiding this comment.
Looks good, but please wrap the commit message at around 100 chars or so.
Collaborator
test this please |
dma_cfg and dma_block_cfg are only partly filled in before dma_config() is called, so the remaining fields (callback, burst lengths, next_block, ...) hold stack garbage. Zero-initialize both structs. Signed-off-by: Stefan Ghetu <stefan.ghetu@nxp.com>
ursus161
force-pushed
the
probe-dma-cfg-init
branch
from
November 17, 2026 09:41
e227fd3 to
231acc0
Compare
dbaluta
approved these changes
Nov 17, 2026
Collaborator
|
LGTM now, @lyakh @lgirdwood please have a quick look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dma_cfg and dma_block_cfg are only partly filled before dma_config(), so the remaining fields (callback, burst lengths, next_block, ...) hold stack garbage. Zero-initialize both structs.