Repository navigation
Conversation
Add HDMI IN support for generic hda topology. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the HDMI input capture and ACE3 topology target changes.
No open issues 🎉
What changed in this PR
Adds sof-hda-generic-ace3-hdmi12.tplg for HDA codecs with HDMI input capture on Panther Lake (ACE3), reusing the generic HDA topology.
Changes:
- Adds HDMI input defaults and conditionally includes capture configuration.
- Registers a development target with two HDMI inputs and NHLT generation.
| File | Description |
|---|---|
| tools/topology/topology2/sof-hda-generic.conf | Enables optional HDMI input capture in the generic HDA topology. |
| tools/topology/topology2/development/tplg-targets.cmake | Defines the ACE3 HDMI input target and its NHLT output. |
Review effort: Balanced
PR 11490: test resultsRun date: 2026-11-19 09:42 UTC Tested commit: d7221c33dfa28124109a3636993766ae69b60ede |
| NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,DMIC0_DEEP_BUFFER=true,DEEPBUFFER_FW_DMA_MS=10,\ | ||
| DMIC0_ENHANCED_CAPTURE=true,EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default" | ||
|
|
||
| "sof-hda-generic\;sof-hda-generic-ace3-hdmi12\;PLATFORM=ptl,HDA_CONFIG=mix,HDMI_IN_CAPTURE=true,HDMI_IN_1_INDEX=1,\ |
There was a problem hiding this comment.
I know that this was the name that was used, but I would be hard pressed to guess what this config is based on the name.
should we use better name? sof-hda-generic-ace3-2-hdmi-in.tplg / sof-hda-generic-ace3-2x-hdmi-in.tplg.
There was a problem hiding this comment.
hdmi12 means port 1 and 2 that indicates 2 hdmi-in. Changed the name to sof-hda-generic-ace3-hdmi-in-port12.
There was a problem hiding this comment.
and how do we know what is printed near the port and which is 1 and which is 2?
Add topology for HDA codec + HDMI IN port 1 and 2. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
176549a to
d7221c3
Compare
kv2019i
left a comment
There was a problem hiding this comment.
Thanks, the updated name is better.
Add sof-hda-generic-ace3-hdmi12.tplg for HDA codecs with HDMI IN configuration.