Repository navigation
Conversation
The /dev/null optimisation turned on -s, which also hides error messages, so 'cmp a missing > /dev/null' exited 2 without saying why and 'cmp -l -s > /dev/null' no longer rejected the two options. Track the redirect separately and only skip the difference and EOF reports for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #345.
When stdout is
/dev/null,parse_paramssetquiet, which is also what-ssets and what hides error messages. Socmp a missing > /dev/nullexited 2 with nothing on stderr, andcmp -l -s a b > /dev/nullwas accepted.The redirect now has its own flag. It only skips the difference and EOF reports; errors are hidden by
-salone, and the-l/-scheck runs first.The test from the issue doesn't compile (
assert_cmd::Commandhas nostdout()), so the new tests usestd::process::Commandlikecmp_fast_paths.