Repository navigation
Conversation
For 'diff FILE DIR' the entry of DIR was looked up with Path::exists(), which follows symlinks. A dangling symlink named exactly like FILE counted as missing, and a differently cased entry was compared instead when the directory listed it first.
…gling-link # Conflicts: # tests/by-util/test_diff.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357.
directory_entryusedPath::exists(), which follows symlinks, so a dangling symlink with the exact name counted as missing and a case variant was compared instead. Usesymlink_metadata().The bug only shows when the directory lists the case variant before the link (tmpfs lists newest first, btrfs oldest first), so the test builds both layouts.