Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362.
--palettevalues were copied as is, so--palette='ad=\061;32'put a literal\061in the output, and\:ended the value.Values are now decoded the way GNU diff 3.12 does it:
\NNNoctal and\xHHhex (any number of digits, low byte kept),\a \b \e \f \n \r \t \v,\?for DEL,\_for space; any other escaped character stands for itself, so\:and\\work^Xcaret notation for@to~, and^?for DEL\or^, or^followed by something else, is rejected with the same two messages as GNU (unrecognized prefix: ad,unparsable value for --palette)The palette entries are bytes now, since a value can decode to anything.
One difference left on purpose: for
^?GNU prints DEL followed by a stray?, which looks like a bug there. This prints DEL only.