Repository navigation
Conversation
|
GNU diffutils testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354.
do_expand_tabsmeasured the Unicode width of everything between tabs, so control characters threw the padding off. It now tracks the column like GNU diff 3.12 does with-t:\rgoes back to column 0. In the normal and context formats the line marker (<,!, ...) is written again after it when more text follows; unified and ed don't repeat theirs, same as GNU.\bgoes one column back. At column 0 it is dropped, which is also what GNU prints.Text runs between control characters are still measured with
UnicodeWidthStr, so the ZWJ emoji test keeps its width.do_write_linetakes the marker as a new argument.Checked against GNU diff in
en_US.UTF-8for the normal, unified, context and ed formats. In the C locale GNU counts every non-ASCII byte as one column; that was already different here and isn't touched.