Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator currently exports only ASCII. This adds available Cyrillic glyphs (U+0400–U+04FF) and note punctuation (U+00AB/U+00BB/U+2013/U+2014/U+2122) using
GetGlyphOutlineWand explicitGLYPH_U32entries, while retaining the legacy sequential ASCII entries.extend_font.pyappends generated Unicode glyphs to an existing atlas. This preserves existing pixels, coordinates and metrics when the current font/rasterizer would otherwise change them, and skips Unicode codepoints already present so that extending a font again does not replace them. It requires Pillow and matching font heights. Font licensing remains separate from the generator license.This draft is the asset-generation part of Cyrillic support for PoB Notes. It needs a corresponding SimpleGraphic reader change; it does not localize game data or the UI.
Validation on Windows with VS2022:
tests/fontgen_test.cppand the asset-generation runner compiled with VS2022 x86, exit 0; 9 native tests pass. The five punctuation cases failed before the follow-up change.python -m unittest discover -s tests -p test_extend_font.py: 5 tests pass, including an existing-Unicode regression that fails without the duplicate-codepoint guard.git diff --check: exit 0.The README documents the format and reproduction commands. The Python tests use generated temporary fixtures; no font binaries are added to this repository.
Companion drafts: SimpleGraphic #122 and PoB #10452.