Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode character events currently go through the named-key lookup, so typing Russian produces
?. The renderer also only addresses the first 128 glyphs. This change passes character events toOnCharas UTF-8 and reads optional, explicitly indexedGLYPH_U32bitmap glyphs.Width measurement, cursor hit testing and drawing use the same Unicode glyph lookup. Legacy ASCII entries remain supported, named key events retain their current behavior, and missing glyphs keep the existing
[U+XXXX]fallback.This draft supports a coordinated Cyrillic Notes change in PoB. The companion font generator PR produces the new entries. PoB also needs updated font assets and UTF-8-safe editing; this is not a UI/game-data localization change.
Validation on Windows x64, VS2022, Release:
LEFT. Original DLL: 6 failures; mutation probes detect broken ASCII/named-key delivery.git -c core.whitespace=cr-at-eol diff --check: exit 0 (existing sources use CRLF).tests/README.mdandtests/run-windows.ps1describe reproducible runtime tests. The Windows input driver targets only its own process/window and all waits are bounded. Renderer tests require the companion extended font assets.Companion application/assets draft: PoB #10452.