Skip to content

Add support for many Wickerman Viscera modifiers - #10451

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:submit/wickerman-modifier-support-v2
Open

AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:submit/wickerman-modifier-support-v2

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Adds support for many Wickerman modifiers that were either unrecognized or weren't affecting calculations. Skipped adding many modifiers that don't meaningfully get used in build calcs like -# Physical Damage taken from Hits by Animals. Can provide a full list of the mods I excluded if needed.

Curses granted by wearing a # of influenced items will create an enabled skill. Works with equipped items or as a custom modifier. This works with multi-word curse names like Assassin's Mark.

New or corrected modifier support:

  • #% of Physical Damage over Time taken as Chaos Damage
  • #% reduced Burning Damage taken
  • Curse Enemies with <Curse Name> on Hit if # <Influence> Items are Equipped
  • Minions created Recently have Onslaught
  • Minions deal #% increased Damage if you've Hit Recently
  • Minions have #% increased Movement Speed if you've used a Minion Skill Recently
  • #% chance to Hinder Enemies on Hit with Spells
  • Immune to Hinder
  • #% Global chance to Blind Enemies on Hit
  • #% increased Damage while Blind
  • Enemies you Blind while in Sand Stance take #% increased Damage
  • #% increased Life Recovery rate per #% missing Unreserved Life
  • Skills fire an additional Projectile if you've been Hit Recently
  • Skills fire an additional Projectile if you've used a Movement Skill Recently
  • Skills that Cost Life have #% chance to deal Double Damage
  • Hits have #% chance to treat Enemy Monster Cold Resistance values as inverted
  • Hits have #% chance to treat Enemy Monster Fire Resistance values as inverted
  • Hits have #% chance to treat Enemy Monster Lightning Resistance values as inverted
  • Damaging Ailments inflicted by Minions deal damage #% Faster
  • Melee Critical Strikes Poison the Enemy
  • +# to number of Sacred Wisps Summoned
  • Offerings you create also grant #% increased Damage
  • Iron Flasks applied to you have #% increased Effect
  • #% increased Evasion Rating from Equipped Helmet, Body Armour Gloves and Boots
  • #% increased Armour from Equipped Helmet, Body Armour, Gloves, and Boots
  • #% increased bonuses gained from Equipped Gloves
  • #% increased bonuses gained from Equipped Boots
  • #% reduced bonuses gained from Equipped Boots
  • +#% to Maximum Effect of Chill
  • You and Allies within # metres deal # to # additional Cold Damage
  • Skills socketed in Equipped Boots have #% increased Mana Cost Efficiency
  • Increases and Reductions to Light Radius also apply to Life Regeneration Rate at #% value
  • Increases and Reductions to Mana Regeneration Rate also apply to Energy Shield Recharge Rate at #% of their value
  • Enemies within # metres are Scorched

Support details:

  • Hinder and Blind still have to be manually enabled in configs
  • Added a new condition for "Missing unreserved Life" with a manual override.
  • Additional Sacred Wisps summoned are reported per trigger. Sustained DPS still uses the maximum active Wisp count.
  • Glove/boot bonuses extend the existing global bonus scaling to Wickerman items and Custom Modifiers.
  • The modifier You and Allies within # metres deal # to # additional Cold Damage doesn't check for distance, it just assumes the flat damage bonus.
  • Similarly Enemies within # metres are Scorched just assumes the distance check succeeds and applies the 10% base effect of Scorch.

Steps taken to verify a working solution:

  • Manually tested ~half of the new modifier checks
  • Added 26 focused regression cases covering the observed bugs and calculation/state boundaries. All 26 fail against the unpatched base and pass with the modifier changes.
  • Ran the modifier test suite: 692 passed, 1 pre-existing failure (TWWT), 0 errors.
  • Checked all 37 changed generated modifier cache entries against fresh parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant