Repository navigation
fix: correct Chinese name typos in species, form and item names - #1712
Merged
Merged
Conversation
4 tasks done
Naramsim
approved these changes
Nov 11, 2026
|
This Pull Request won't be deployed since the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Corrects 15 Chinese name cells in three CSV files. No rows are added or removed.
pokemon_species_names.csvpokemon_form_names.csv(zh-Hans)poltchageist-counterfeit: 高檔貨的樣子 → 冒牌货的样子. The old value was the Traditional name of the other form (10447, Artisan Form).ogerpon-cornerstone-mask: 礎石面具 → 础石面具. The Simplified row held the Traditional text.item_names.csvSource
Each new value is an exact line in the game text dumps at abcboy101/poke-corpus (
corpus/<Game>/zh-Hans_*.txtandzh-Hant_*.txt):The same values appear in PKHeX's text resources (
text_Species,text_Formsandtext_Itemsfor zh-Hans and zh-Hant).How to test
Data-only change. Build the database (
make build-db) and check thenamesof/api/v2/pokemon-species/312/,/api/v2/pokemon-form/1012/and/api/v2/item/2262/.AI coding assistance disclosure
I used Claude Code to compare the zh-Hans and zh-Hant name rows against the game text dumps and to apply the 15 edits. I checked each changed row against the source myself.
Contributor check list