Repository navigation
HttpClientBuilder: honor disableDefaultUserAgent() - #931
Merged
arturobernalg merged 1 commit intoNov 14, 2026
Merged
Conversation
Member
|
@arturobernalg |
arturobernalg
force-pushed
the
fix-default-user-agent
branch
from
November 7, 2026 13:33
2d1d276 to
6a5db3a
Compare
ok2c
approved these changes
Nov 7, 2026
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class TestHttpClientBuilderUserAgent extends AbstractIntegrationTestBase { |
Member
There was a problem hiding this comment.
@arturobernalg Drop this test class. It is not worth it.
…no-op The option has had no effect since the default User-Agent guard was dropped together with the http.agent system property support, and the async builders do not have it. The method is now deprecated and ignored.
arturobernalg
force-pushed
the
fix-default-user-agent
branch
from
November 14, 2026 13:23
6a5db3a to
7f474a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
defaultUserAgentDisabledguard was dropped together with thehttp.agentsystem property support, so the builder set the default User-Agent header regardless ofdisableDefaultUserAgent().