Skip to content

HttpClientBuilder: honor disableDefaultUserAgent() #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Nov 14, 2026
Merged

HttpClientBuilder: honor disableDefaultUserAgent() #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ private ExecInterceptorEntry(
private boolean cookieManagementDisabled;
private boolean authCachingDisabled;
private boolean connectionStateDisabled;
private boolean defaultUserAgentDisabled;
private ProxySelector proxySelector;

private boolean tlsRequired;
Expand Down Expand Up @@ -777,13 +776,14 @@ public final HttpClientBuilder evictIdleConnections(final TimeValue maxIdleTime)
}

/**
* Disables the default user agent set by this builder if none has been provided by the user.
* Ignored.
*
* @return this instance.
* @since 4.5.7
* @deprecated This method has no effect and calls to it can be removed.
*/
@Deprecated
public final HttpClientBuilder disableDefaultUserAgent() {
this.defaultUserAgentDisabled = true;
return this;
}

Expand Down
Loading