Repository navigation
HTTPCORE-804: H2Config.copy() does not copy maxContinuations - #748
Merged
arturobernalg merged 1 commit intoNov 14, 2026
Merged
arturobernalg merged 1 commit into
arturobernalg merged 1 commit into
Conversation
The copied builder silently reset the limit to the default (100), even when the source config had a custom value. The only production caller (WebSocketH2ServerBootstrap, client repo) always goes through copy() since push is on by default, so a configured limit never took effect.
ok2c
approved these changes
Nov 14, 2026
Member
|
@arturobernalg Please cherry-pick to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copied builder silently reset the limit to the default (100), even when the source config had a custom value. The only production caller (WebSocketH2ServerBootstrap, client repo) always goes through copy() since push is on by default, so a configured limit never took effect.