Skip to content

HTTPCORE-804: H2Config.copy() does not copy maxContinuations #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Nov 14, 2026
Merged

HTTPCORE-804: H2Config.copy() does not copy maxContinuations #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion httpcore5-h2/src/main/java/org/apache/hc/core5/http2/config/H2Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ public static H2Config.Builder copy(final H2Config config) {
.setInitialWindowSize(config.getInitialWindowSize())
.setMaxFrameSize(config.getMaxFrameSize())
.setMaxHeaderListSize(config.getMaxHeaderListSize())
.setCompressionEnabled(config.isCompressionEnabled());
.setCompressionEnabled(config.isCompressionEnabled())
.setMaxContinuations(config.getMaxContinuations());
}

public static class Builder {
Expand Down
4 changes: 3 additions & 1 deletion httpcore5-h2/src/test/java/org/apache/hc/core5/http2/config/H2ConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ void copy() {
.setMaxFrameSize(16384)
.setPushEnabled(true)
.setCompressionEnabled(true)
.setMaxContinuations(5)
.build();

final H2Config.Builder builder = H2Config.copy(h2Config);
Expand All @@ -82,7 +83,8 @@ void copy() {
() -> assertEquals(h2Config.getInitialWindowSize(), h2Config2.getInitialWindowSize()),
() -> assertEquals(h2Config.getMaxConcurrentStreams(), h2Config2.getMaxConcurrentStreams()),
() -> assertEquals(h2Config.getMaxFrameSize(), h2Config2.getMaxFrameSize()),
() -> assertEquals(h2Config.getMaxHeaderListSize(), h2Config2.getMaxHeaderListSize())
() -> assertEquals(h2Config.getMaxHeaderListSize(), h2Config2.getMaxHeaderListSize()),
() -> assertEquals(h2Config.getMaxContinuations(), h2Config2.getMaxContinuations())
);

}
Expand Down
Loading