Repository navigation
Conversation
Extract a focused piece from the metadata table implementation with its tests. Co-authored-by: Codex <codex@openai.com>
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest-backed metadata tables need a fallible row source that can be consumed lazily. Add
MakeMetadataBatchStreamoverloads forStream<Row>and vectors, with the per-row callback retained as its concrete type.Validate schema, source, callback, and batch size before exporting an Arrow C stream. Source/append failures and exhaustion are terminal, and no row builder is allocated after exhaustion. Focused tests cover invalid inputs, several lazy batches, repeated end-of-stream calls, and sticky append failures.
Extracted from #1120. Builds directly on main and has no dependency on the other metadata-table PRs.
Validation: 58 metadata tests and C++20 compatibility passed in a standalone static Debug build. Pre-commit and clang-tidy 22.1.8 passed. The full split composition passed 144 tests with one expected format-version skip.