Repository navigation
Conversation
dheeren-gaud
previously approved these changes
Feb 10, 2026
- LTS-5486: the README told users to run `npx browserstack-cli load run`, but this sample never installs browserstack-node-sdk (which ships the browserstack-cli bin), so npx fetched the unrelated third-party `browserstack-cli` package from npm with BROWSERSTACK_ACCESS_KEY in the environment. Point the README at the official CLI binary download used by the Selenium and cucumber-testng samples instead. - LTS-5502: Semgrep image had no tag (pulled :latest); pin to 1.166.0@sha256:c180f0c9..., same as the Playwright sample. - LTS-5492: override piscina 4.9.2 -> 4.9.4 (GHSA-x9g3-xrwr-cwfg, GHSA-67c8-pqhq-4rmx). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The copy of this sample bundled in load-testing-backend (sample/sample-nightwatch-repo.zip) was hardened under LTS-4698 with 13 security overrides, but the change never came back to this repo. Take its package.json and package-lock.json as-is, with the piscina override raised to ^4.9.4 (LTS-5492). The repo and the bundled zip now ship the same dependency tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The yml carried the backend's internal shape (loadTestName, fileKey, testScript, language: '', loadProfile: constant, loadProfileStages), which browserstack-cli rejects as invalid keys. Rewrite it per the CLI's Nightwatch sample, keeping the same vus / duration / region. Verified with `browserstack-cli load run`: completed, 1792 requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…curity LTS-5442: run the official CLI, pin Semgrep, patch piscina
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
MihirR-BS
added a commit
that referenced
this pull request
Nov 5, 2026
…ing samples main held only the README and .github/, while the sample itself lived on the Nightwatch-sample-repo branch (PR #1, by amitsi-bs). That sample is now on main, next to the digest-pinned Semgrep workflow, in the same shape as the Playwright and WebdriverIO samples: - browserstack-load.yml, nightwatch.conf.js, package.json, tests/ and the README from Nightwatch-sample-repo (README: the config file is browserstack-load.yml). The branch's stray .DS_Store is left out. - .gitignore (node_modules, log, .DS_Store) and the SC-12282 supply-chain .npmrc (ignore-scripts, save-exact, min-release-age, ...) the sibling samples use. - package-lock.json refreshed within the existing package.json ranges, so the sample lands with no high npm-audit finding: nightwatch 3.16.0, mocha 10.8.2, brace-expansion / js-yaml / diff / serialize-javascript patches. Two moderates (nightwatch -> uuid) remain; npm's only fix is a nightwatch 2.x downgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi @amitsi-bs, #3 carries this branch's sample onto What #3 changes compared with this branch:
The tests and config are unchanged. Leaving the close to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.