Repository navigation
Give DefaultProgress a single scope annotation - #139
Merged
Merged
Conversation
Guice rejects a class carrying both @singleton and @MojoExecutionScoped, which broke every plugin realm containing the jar. DefaultProgress takes a MojoExecution, so it is per-execution; do not add @singleton back. Fixes #127
slachiewicz
marked this pull request as ready for review
November 14, 2026 12:56
This was referenced Nov 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guice rejects a class with two scope annotations, so
@Singletonplus@MojoExecutionScopedonDefaultProgressbroke every realm containing the 1.3.0 jar.DefaultProgresstakes aMojoExecution, so@MojoExecutionScopedstays. The module skips tests, so this has no unit test.Fixes #127
Verified: issue reproducer and a probe mojo injecting
Progresson Maven 3.9.16, 3.10.0-rc-1 and 4.0.0-rc-7, plus the probe as an<extensions>true</extensions>plugin and with the jar in.mvn/extensions.xmlon 3.9.16 and 4.0.0-rc-7 → 1.3.0 fails withDuplicateScopeAnnotations, this branch passes with oneDefaultProgressper mojo execution.