Repository navigation
Run SDK Docker builds as the host user - #575
Merged
Merged
Conversation
Container root owns generated files on a normal Docker daemon, so a later checkout cannot replace them. Rootless Docker still runs as container root because that user is already the host user. Co-authored-by: Cursor <cursoragent@cursor.com>
jspaetzel
marked this pull request as ready for review
October 12, 2026 21:00
jspaetzel
marked this pull request as draft
October 12, 2026 21:09
Shared docker-run and php-in-docker wrappers replace the copied root invocations, and package caches live in host .docker directories so a non-root user can write them. Co-authored-by: Cursor <cursoragent@cursor.com>
jspaetzel
changed the title
jspaetzel
marked this pull request as ready for review
October 12, 2026 21:18
Keep trunk's generator and runtime upgrades, and keep docker-run as the place that chooses the container user. Co-authored-by: Cursor <cursoragent@cursor.com>
erkkinen
reviewed
Nov 4, 2026
3 of 4 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
A directory glob covers new wrappers without listing each filename. Co-authored-by: Cursor <cursoragent@cursor.com>
The workflow already watches these directories, and a new wrapper is picked up when it execs docker-run or php-in-docker. Co-authored-by: Cursor <cursoragent@cursor.com>
The macOS Bash check now lives in hellosign/bash32-action, so this repo only passes the script globs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git checkout.bin/docker-user-argskeepsroot:rooton rootless Docker (container root is already the host user) and uses the host uid/gid on rootful Docker.bin/docker-runapplies that to every SDKdocker run.run-build, and the sandbox scripts use it. Package caches are host directories under.dockerso the non-root user can write them.bin/redoc-containerstill runs as root because nginx binds port 80 and does not write the checkout.Test plan
bin/docker-run -v "$PWD:/work" -w /work alpine touch probecreates a file owned by the host user./generate-sdks -t php(and one other language) leaves the SDK tree writable by the developerdocker-user-argsprints--user root:root)DOCKER_RUN_AS_ROOT=1restores the old root behavior