Repository navigation
Conversation
This was referenced Oct 25, 2026
Core gives a Local Activity the Workflow Task attempt that dispatched it, and the run's last completed and failed tasks. The bump to C1 also takes the Core changes on sdk-rust `main` since the pin.
moetemp
force-pushed
the
moe/brook/review/g3-workflow-task
branch
from
October 27, 2026 09:07
bb40759 to
58598ae
Compare
Core moved `workflow_task` to field 21 when it merged, and added the attempt and the started time of the run's last completed Workflow Task.
Owner
Author
|
Closed in favor of #381, the combined branch, which has this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds
activity.Info.workflow_taskfor Local Activities, and bumps Core to the merged C1, which adds field 21 toActivityTask.Start.activity.WorkflowTaskAttemptis experimental andNonefor other activities. Retries that the Worker runs in the same task get the same value. It also hasprevious_attemptandprevious_started_timeof the run's last completed Workflow Task.4b3af8dbontemporalio/sdk-rust(temporalio/sdk-rust#1703). C1 was squash-merged, sopoe update-corerefuses the move from the pre-merge pin. I moved the pin by hand and added Core's new changelog entries.breaking-changesis already met onmainsincetemporalio/sdk-python#2010.Depends on C1 (
temporalio/sdk-rust#1703), which is merged.Part of the Brook review series.
Why?
A Local Activity can't find out which Workflow Task attempt dispatched it, or which earlier tasks of its run failed. Streams needs both, since readers withdraw the Records that a failed task's Local Activities wrote. Other users can scope an idempotency key to the task attempt.
Checklist
poe bridge-lint,poe lint,poe gen-docs, the new Local Activity test and the Worker, client, Workflow and Nexus suites.