Repository navigation
feat(events): add batch operations (TT-5544) - #770
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 43 43
Lines 1041 1045 +4
Branches 90 91 +1
=======================================
+ Hits 1028 1032 +4
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
events.batch()for grant-scoped Google and Microsoft event create/update/delete operations. Typed operations reuse the existing event request models, and a dedicated response exposes ordered per-item results, including failures returned with HTTP 207. Nested event metadata keys are preserved during request and response conversion. Grant identifiers are validated before HTTP so blank, non-string, and literal or encoded URL dot segments cannot change the grant-scoped path.Includes HTTP regression coverage for query/body serialization, successful and mixed/all-failed 207 responses, zero retry delays, normal 400 errors, and compile-time required fields. The standalone
examples/calendars/event_batch.tsexample shows one caller-controlled retry and excludes any item withproviderEventCreated: true.Implements TT-5544, part of TT-5542. Ruby counterpart: nylas/nylas-ruby#553.
Validation: the full Node.js 18/20/24/25 CI matrix passed, including the batch HTTP/type tests and invalid-identifier no-network regressions; build, CommonJS/ESM package import checks, ESLint, Prettier, and diff checks passed. Example TypeScript and formatting checks also passed. Optional live staging smoke test was not run.
@radenkovic @googsvg, please review. @radenkovic, as the Node task owner, please merge and release/deploy this SDK through the normal release process once approved and CI passes. @AaronDDM is assigned as the Ruby task owner and cross-SDK contact; GitHub does not allow requesting a review from the PR author.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.