Repository navigation
feat(events): add batch operations (TT-5546) - #553
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
events.batchfor grant-scoped Google and Microsoft event create/update/delete operations. It follows this SDK's hash inputs and[results, request_id, headers]return tuple, with typed YARD field documentation. Ordered per-item results are returned for HTTP 200 and mixed/all-failed HTTP 207 responses; invalid whole requests raise the normal API error. The grant identifier is validated before HTTP and encoded as a single URL path segment; blank, non-string, and URL dot-segment identifiers are rejected.Includes six actual HTTP regression examples plus a no-network invalid-identifier regression covering serialization/query parameters, path encoding, 200/207 responses, zero retry delays, provider errors, duplicate-prevention metadata, and normal 400 errors. The standalone
examples/events/event_batch_example.rbexample retries eligible failures once after the provider delay and never retries an item withprovider_event_created: true.Implements TT-5546, part of TT-5542. Node counterpart: nylas/nylas-nodejs#770.
Validation: all 327 RSpec examples passed; full RuboCop, YARD generation, gem build, and diff checks passed. Local verification used Ruby 4.0.7; CI covers Ruby 3.0–3.2. Example syntax and RuboCop checks also passed. Optional live staging smoke test was not run.
@radenkovic @googsvg, please review. @AaronDDM, as the Ruby task owner, please merge and release/deploy this SDK through the normal release process once approved and CI passes. GitHub does not allow requesting a review from the PR author, so the Ruby owner is assigned and the parent task owner is requested for independent review.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.