Skip to content

gh-161270: fix always-skipped InitConfigTests in test_embed - #161278

Merged
vstinner merged 4 commits into
python:mainfrom
NekoAsakura:gh-161270/bolt-skipif
Nov 4, 2026
Merged

gh-161270: fix always-skipped InitConfigTests in test_embed#161278
vstinner merged 4 commits into
python:mainfrom
NekoAsakura:gh-161270/bolt-skipif

Conversation

@NekoAsakura

@NekoAsakura NekoAsakura commented Nov 3, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Nov 3, 2026
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Nov 3, 2026
@NekoAsakura NekoAsakura added skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 3, 2026
vstinner
vstinner approved these changes Nov 3, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Oh, well spotted!

@vstinner vstinner mentioned this pull request Nov 3, 2026
Merged
@vstinner
vstinner enabled auto-merge (squash) November 3, 2026 23:22
@NekoAsakura

NekoAsakura commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Ah, looks like we've caught something. Issue coming up.

@NekoAsakura NekoAsakura mentioned this pull request Nov 4, 2026
Closed
@vstinner

vstinner commented Nov 4, 2026

Copy link
Copy Markdown
Member

Ah, looks like we've caught something. Issue coming up.

Aha, I see that you created issue gh-161288.

I don't think that it's worth it to bother with testing perf support in test_embed, so I suggest to skip tests on perf_profiling: #161288 (comment).

@NekoAsakura

NekoAsakura commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

#158336

@vstinner
vstinner merged commit 9aa731f into python:main Nov 4, 2026
50 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 4, 2026

Copy link
Copy Markdown

Thanks @NekoAsakura for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 4, 2026

Copy link
Copy Markdown

GH-161369 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 4, 2026
@bedevere-app

bedevere-app Bot commented Nov 4, 2026

Copy link
Copy Markdown

GH-161370 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 4, 2026
vstinner pushed a commit that referenced this pull request Nov 5, 2026
@miss-islington @NekoAsakura
[3.14] gh-161270: Fix always-skipped InitConfigTests in test_embed (
a2e9da3 
GH-161278) (#161370)

gh-161270: Fix always-skipped `InitConfigTests` in `test_embed` (GH-161278)
(cherry picked from commit 9aa731f)

Co-authored-by: Neko Asakura <neko.asakura@outlook.com>
vstinner pushed a commit that referenced this pull request Nov 5, 2026
@miss-islington @NekoAsakura
[3.15] gh-161270: Fix always-skipped InitConfigTests in test_embed (
0d4914c 
GH-161278) (#161369)

gh-161270: Fix always-skipped `InitConfigTests` in `test_embed` (GH-161278)
(cherry picked from commit 9aa731f)

Co-authored-by: Neko Asakura <neko.asakura@outlook.com>
@NekoAsakura
NekoAsakura deleted the gh-161270/bolt-skipif branch November 5, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NekoAsakura @vstinner