Repository navigation
Close files inspected by LineEndings - #921
Merged
Merged
Conversation
LineEndings opens every inspected file without explicitly closing it. Large commits and whole-repository checks can exhaust file descriptors before garbage collection runs, including in other concurrent hooks. Use a File.open block so each file closes after validation. Keep the encoding-warning handler inside the block so it can still read the file's line number before the file closes.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LineEndings opens every inspected file without explicitly closing it. Large commits and whole-repository checks can exhaust file descriptors before garbage collection runs, including in other concurrent hooks.
Use a
File.openblock so each file closes after validation. Keep the encoding-warning handler inside the block so it can still read the file's line number before the file closes.