Skip to content

Close files inspected by LineEndings #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sds merged 1 commit into from
Nov 6, 2026
Merged

Close files inspected by LineEndings #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/overcommit/hook/pre_commit/line_endings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ def run
messages = []

offending_files.map do |file_name|
file = File.open(file_name)
begin
File.open(file_name) do |file|
messages += check_file(file, file_name)
rescue ArgumentError => e
# File is likely a binary file which this check should ignore, but
Expand Down
Loading